Project

General

Profile

Defect #272

getTimeline() doesn't show replies

Added by Robert Ivens about 13 years ago. Updated about 13 years ago.

Status:
Closed
Priority:
Normal
Start date:
04/23/2011
Due date:
% Done:

0%

Estimated time:
Browser (if web client):

Description

Not sure if this is by design (and this should then be a feature request) or that this is a bug.
Perhaps another parameter?Or should I always request the replies separately ?


Files

twitter_inconsistencies.png (103 KB) twitter_inconsistencies.png Patrick Talbot, 04/23/2011 11:33 PM

History

#1

Updated by Patrick Talbot about 13 years ago

Not sure what you mean by not showing replies.
If the replies are direct messages, then no, they are not part of the timeline. (Direct messages are private)
Otherwise, I see the replies I've made in my timeline, how come you don't?

#2

Updated by Robert Ivens about 13 years ago

This what I get when I get the Replies:

61869459710812160 | servoystuff | Robert Ivens If you have a good looking sample solution, maybe you can commit it to the project?
61868005839224830 | servoystuff | Robert Ivens Yes, and I tried to implement RateLimit but the twitter is not responding on these calls
61867378656555010 | servoystuff | Robert Ivens BTW, you should use plugins.twitter.reply(account, message, inReplyTo, user); to avoid a security exception when replying
61866714429792260 | servoystuff | Robert Ivens Well there's certainly no harm in that! ;)
61860538535264260 | servoystuff | Robert Ivens The Twitter API has a few quirks, not too sure how everything is working yet...

This what I get when I get the Direct Messages:

2877124103 | servoystuff | Hope you are having fun ;-)
2873407822 | servoystuff | Test of direct message

This is my timeline:

61870843625603070 | roclasi | Patrick Talbot I will commit it back when I have most of it done
61866044867870720 | roclasi | Patrick Talbot It seems to work pretty nice so far. Only thing is the error handling.

#3

Updated by Patrick Talbot about 13 years ago

The replies and direct messages are mine: they shouldn't appear in your time line!
If you don't set the user (or set it to roclasi) and getReplies(), you should see yours.
Direct message are never part of your timeline (even in the twitter UI)

#4

Updated by Robert Ivens about 13 years ago

What about the tweets of the people I am following? How do I get those ?

#5

Updated by Patrick Talbot about 13 years ago

Ah! You're right :) I should have used getFriendsTimeLine() instead of getUserTimeLine()
Although I guess it could be useful to have only the userTimeLine as well...

Maybe I can change getTimeLine() to use getFriendsTimeLine() (your timeline + the tweets of the people you are following)
And add a getUserTimeLine() where you will only get yours?

How does that sound?

#6

Updated by Patrick Talbot about 13 years ago

One thing though is that there is no getFriendsTimeLine() with retweets...

#7

Updated by Robert Ivens about 13 years ago

Perhaps getTimeLine(account, mineOnly, withRetweets) ?
And a getFriendsTimeline(account) ?

#8

Updated by Patrick Talbot about 13 years ago

getTimeLine(account, mineOnly, withRetweets, [max])
if mineOnly == false it would be the same as: getFriendsTimeLine(account, [max]) actually

I might have to subclass the getFriensTimeLine() to add the retweets to the parameters, will have a look.

#9

Updated by Robert Ivens about 13 years ago

If mineOnly == false then you would get the full timeline with friends.
Then again if we go that route then we might have to add replies too....

Perhaps better to keep it all separate so we can handle it all ourselves.

#10

Updated by Patrick Talbot about 13 years ago

Robert Ivens wrote:

If mineOnly == false then you would get the full timeline with friends.

Which is exactly the same as getFriendsTimeLine(), right? (friends timeline = friends + mine timeline)

Now it also all depends on what you want to emulate, one thing is for sure is that Twitter is clearly returning either your own only or yours AND your friends. As for retweets this is not clear (it is a parameter in the call, not sure how it applies to a call to friends time line).

One thing I clearly don't like about the twitter home for example is the fact that I see tweets not only from me and the people I follow, but also from the people followed by the people I follow, which I might not really want).

#11

Updated by Robert Ivens about 13 years ago

Ah, I thought getFriendsTimeline would only get your friends tweets. Not your own.

As for the Twitter home page and tweets from people you don't follow. I guess these are retweets or replies. You never should see the tweets from others than your friends.

#12

Updated by Patrick Talbot about 13 years ago

Well looking at my home in twitter, I see tweets from people I don't follow but you do (and they aren't replies): see attached (knowing that I only follow you) - I suppose these are all retweets by you then.

#13

Updated by Robert Ivens about 13 years ago

Correct, you can recognize them via the square chasing arrows icon following 'by ROCLASI'.

#14

Updated by Patrick Talbot about 13 years ago

OK. Now I just tried and the JTwitter API is not returning retweets in the getFriendsTimeLine() :(

And the method calls are private, so I will probably have to change the API... argh, I hate when you have badly conceived API where as soon as you want to do something else than what is already implemented it is not open enough to be subclassed, and you end up having to make you own fork of it to do it right.

#15

Updated by Robert Ivens about 13 years ago

If it's too much work then just let it be. We can always do 2 calls and merge the message array (and sort it) ourselves.

#16

Updated by Patrick Talbot about 13 years ago

No it's not too much work (I can embed that merge in the plugin anyway) it's just that it is a shame to have to do two calls, when all you need to do is actually adding a parameter in the call (include_rts = 1)

#17

Updated by Patrick Talbot about 13 years ago

  • Status changed from New to In Progress
#18

Updated by Patrick Talbot about 13 years ago

I have changed getTimeLine() into getAccountTimeLine() and getUserTimeLine()
The 1st one is merging the getRetweetsByMe to the timeLine, while getUserTimeLine cannot make use of getRetweetsByMe

#19

Updated by Patrick Talbot about 13 years ago

Seems fixed to me with 0.8.4 - please confirm

#20

Updated by Robert Ivens about 13 years ago

  • Status changed from In Progress to Closed

It shows replies now :)

Also available in: Atom PDF