Project

General

Profile

Defect #1256

Template crashes the complete servoy server

Added by Wouter Moerdijk over 6 years ago. Updated over 6 years ago.

Status:
Rejected
Priority:
Urgent
Assignee:
-
Category:
-
Target version:
-
Start date:
09/14/2017
Due date:
% Done:

0%

Estimated time:
Browser (if web client):

Description

When specifying a @page css section the margin-left,top etc need to be specified. If you forget to set it the complete servoy server craches.

This is a working copy:
@page {
size: 30mm 12mm;
margin-left: 3mm;
margin-right: 0mm;
margin-top: 4mm;
margin-bottom: 0mm;
}

This crashes the entire servoy service:
@page {
size: 30mm 12mm;
margin-left: 3mm;
margin-right: 0mm;
margin-bottom: 0mm;
}

Problem is that these setting can be manipulated by our customers, so a users can crash the server.

History

#1

Updated by Patrick Talbot over 6 years ago

  • Status changed from New to Rejected

You let users edit the template??? It's a very bad idea.

Now if you are using variables for the size, why don't you put some safe guards if null or empty and put a value in that case?
I don't think it's a good idea to implement that at the Velocity level, this would be hard to do when it's a lot easier to make sure your template is correct...

Also available in: Atom PDF